Fix wrong bound selection in histogram last bucket #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you want me to check in Builder and give you the acceptance. |
|
Let's see first is @VictorVelarde can have a look and make a CR and then yes, it will be very helpful if you could test it in Builder! |
|
The fix LGTM @csubira, and it seems like there is no 'one duplicated bucket issue', so I think we can move on. I have just added 2 specs and made a little refactor to an if, and that's it. |
|
@csobier @VictorVelarde next time ask me for checking the change on staging! |
|
I will Ramiro. Indeed I'll ask you for acceptance after merging another carto.js PR and releasing a new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://github.com/CartoDB/support/issues/1871
Useful comments found in an older closed issue:
#926