Skip to content

Commit

Permalink
Fix warning
Browse files Browse the repository at this point in the history
Avoid overriding special methods such as object_id, send, etc.
  • Loading branch information
amiedes committed Oct 9, 2020
1 parent c9b92ed commit 382bb63
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Development
### Bug fixes / enhancements
* Add DO geography key variables [#15882](https://github.com/CartoDB/cartodb/pull/15882)
* Migrate `ClientApplication` model to `ActiveRecord` [#15886](https://github.com/CartoDB/cartodb/pull/15886)
* Avoid delegating special methods in presenters [#15889](https://github.com/CartoDB/cartodb/pull/15889)

4.42.0 (2020-09-28)
-------------------
Expand Down
2 changes: 1 addition & 1 deletion app/presenters/base_presenter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ def self.object_klass
end

def self.delegated_methods
object_klass.columns.map(&:name).map(&:to_sym) + object_klass.instance_methods
object_klass.columns.map(&:name).map(&:to_sym) + (object_klass.instance_methods - Object.methods)
end

def initialize(object, params = {})
Expand Down

0 comments on commit 382bb63

Please sign in to comment.