Type guessing on import for GEOJSON

[saleiva]

We should contact the same guy that helped us with csv.
cc/ @javisantana

[javisantana]

geojson already has types so in this case we should take care because some users could be using them.
Also there is another fact, we can't be doing this for every format, this should be something horizontal to all the format we import.

I will ask the guy who worked with us

[javisantana]

there was another thing related with integer limits, right? cc @Kartones

[Kartones]

Yes, it seems we're hitting int32 max value (all get converted to number 2147483647) upon importing files with really big integers, like this sample CSV:

CODE,NAME
18001030300,"aaa"
18001030400,"bbbb"

[javisantana]

http://trac.osgeo.org/gdal/wiki/rfc50_ogr_field_subtype

[javisantana]

merged in ogr2ogr master

[saleiva]

😃

[javisantana]

cc @rafatower

[rafatower]

Worth noting: in gdal trunk there must be also a patch for a segfault when imporing csv files

[saleiva]

what do we do with this issue then?

[saleiva]

bump!

[Kartones]

Probably wait until @rafatower comes back from vacations... I'm kind of busy right now to do regression tests or see if everything's fine now :(

[saleiva]

So, @rafatower ?

[rafatower]

Current status:
-[x] the gdal feature is implemented and the ogr2ogr2 binary containing it is in production.
-[ ] the ruby code must make use of it, pretty much like for csv

@javisantana, what's exactly the expectation of this feature? according to doc this is the only change regarding GeoJson:

Changes in drivers
GeoJSON: can read/write OFSTBoolean

[javisantana]

guessing on boolean and dates

[rafatower]

The geojson specification only mentions these types:

The value of the type member must be one of: "Point", "MultiPoint", "LineString", "MultiLineString", "Polygon", "MultiPolygon", "GeometryCollection", "Feature", or "FeatureCollection". The case of the type member values must be as shown here.

Currently dates are imported correctly. Working my way through the code to enable ogr2ogr2 for geojson and boolean values.

[rafatower]

I'm getting this error with ogr2ogr2:

2015-01-20 14:57:51 UTC: ogr2ogr output:    ERROR 4: Unable to open EPSG support file gcs.csv.
Try setting the GDAL_DATA environment variable to point to the
directory containing EPSG csv files.
ERROR 4: Unable to open EPSG support file gcs.csv.
Try setting the GDAL_DATA environment variable to point to the
directory containing EPSG csv files.
Failed to process SRS definition: EPSG:4326

2015-01-20 14:57:51 UTC: ogr2ogr exit code: 256

I think that means we lack one file in the deb package

[rafatower]

To recap:

• I had some problems with the package, but managed to fix it. The work is done here
• The new package is uploaded to launchpad but needs a fix in gdal@trunk. Package shall be easy to update once it is fixed.
• The bug has been reported to our gdal contact and is a BLOCKER
• Short PR for ruby code Use ogr2ogr2 both for csv and geojson files #1036 #1906 - DONE

[rafatower]

And released!