Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking anywhere else but the title on the Widget card do not go to edit widget #13409

Closed
jesusbotella opened this issue Jan 16, 2018 · 5 comments
Assignees
Labels

Comments

@jesusbotella
Copy link
Contributor

Context

Clicking anywhere else but the title on the Widget card do not go to edit widget view.

Steps to Reproduce

  1. Go to any created map
  2. Click on the Widget tab
  3. Try to click on the Source label placed on the widget card

Current Result

It does nothing

widgetcardclick

Expected result

It should redirect me to the view where I can edit the widget I clicked

Browser and version

Google Chrome
Version 63.0.3239.132

@ramiroaznar
Copy link

@arianaescobar this is expected, right? In doing so you can drag and order your widgets...

@arianaescobar
Copy link

Everything should be clickable, the drag and drop doesn't compete with that.

It would similar to what we did for the layers items:
be4f94ac-e2e0-11e6-801b-cdfcf616f821

@ramiroaznar
Copy link

Reviewing again all frontend issues, I think that clicking on everything else but the title should not direct you to the editing module...

@arianaescobar
Copy link

It should, @ramiroaznar. Just like the layers cards do.
If we highlight the whole card with the blue border as soon as the mouse is hovering it, then everywhere you click inside the card should take you to the widgets options.

@Jesus89 Jesus89 self-assigned this Jul 4, 2018
@Jesus89
Copy link
Member

Jesus89 commented Jul 5, 2018

Closed by #14139

In production! 🚀

@Jesus89 Jesus89 closed this as completed Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants