-
Notifications
You must be signed in to change notification settings - Fork 652
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set basemap URL to tiles.basemaps.cartocdn.com #13458
Comments
Suggested domain rewriting table for existing maps, note different domain for enterprise and free:
|
Uhm, we really don't have a good system to differentiate FREE and ENTERPRISE. I mean, we could do it at layer creation time with some small patches to the code, but we don't have a good way to keep it in sync if the user upgrades/churns. Is the different domain per account-type a requirement? If so, we should sit and think about it some more. |
No, we don't need this. Probably we don't have basemap enterprise URLs or requirements anywhere in existing carto maps configs, or in Builder. Enterprise users in Builder/Engine terms are technically just free map users from basemap service point of view, as they do not pay extra for basemaps. Even if they do, then currently they technically use free maps. If they really want, then they can add their enterprise URL as 'custom basemap xyz url' in Builder, from the last 30 day log I found exactly one such map which has requested 2 tiles: https://team.carto.com/u/javi/builder/18eb6018-32a7-455c-b585-d60236b2ae2c/basemap , thats some test I guess. These enterprise domain names URLs are from server log, and it seems that these are directly hardcoded in some user's apps. In this sense the replacement script does not probably need them. |
Indeed, as explained in #12845 (comment) it is one of the steps to have full retina support in our raster basemaps (but not a blocker one) |
While doing this issue #12845, we have seen that we have some links hardcoded that we are using to convert from HTTPS and HTTP. Please take this into account because maybe we have to make changes here. https://github.com/CartoDB/cartodb.js/blob/v4/src/vis/layers-factory.js#L14-L21
|
The new correct http://{s}.basemaps.cartocdn.com supports both http and https, but I would prefer usage of https as default whenever possible. I don't know how this would really affect HTTPS_TO_HTTP, or how (and why) this works, maybe add something like |
cc @jorgesancha - this is something what is needed for CDN migration from CARTO, and in the other hand, it could be done already now. Can you make sure it is in the boards of respective team(s)? |
@javitonino please go ahead and add this to the backend kanban |
This is done for new maps. I'm creating https://github.com/CartoDB/cartodb-management/issues/5144 for the migration of existing maps. |
Change any basemap URLs in Builder configurations from *global.ssl.fastly.net to CDN-independent tiles.basemaps.cartocdn.com.
Required for CDN change (https://github.com/CartoDB/cartodb-management/issues/5093)
I would retire domain sharding (i.e. a-, b- etc subdomains), as most modern browsers will do HTTP/2 multiplexing anyway and sharding would just cost extra time due to DNS lookups.
Fixes also #13159 .
There should be no pre-requisites for this, can be done immediately.
Extra step: Existing map configurations should be rewritten - Something similar to update_nokia_layers in layers.rake as hinted by @javitonino.
The text was updated successfully, but these errors were encountered: