Suggestion: Send an email to user when sync has reached max_retries

[iriberri]

Feedback from @d4weed

When a sync table fails to be synced and it gets to "max retries", it's never synced again. We could warn the users through an email that this is happening so that they're aware that their data will be no longer updated.

cc @saleiva

[saleiva]

Like it

Forcing the sync manually gets the sync table back, right?

[iriberri]

If you force it, it gets synced if the datasource is still ok.

But: A doubt I have is that the retries are not going back to 0 when you force one (I think), as far as i've seen by investigating the logs.

(Check retried times with values 11 & 12, when maximum is 10 if i'm not wrong)

[d4weed]

oh, this could be what's causing our issues. If the retry count doesn't get
reset that would mean just one import failure leaves the table unconnected
again. Maybe treating a manual sync as a re-setter would be better, as
otherwise older tables will always have more chances to fail than newer
ones.

A retry count of 10 can easily be met in a few months of syncing just due
to network failures

On Tue, May 5, 2015 at 1:52 PM, Carla notifications@github.com wrote:

If you force it, it gets synced if the datasource is still ok.

But: A doubt I have is that the retries are not going back to 0 when you
force one (I think), as far as i've seen by investigating the logs.

(Check retried times with values 11 & 12, when maximum is 10 if i'm not
wrong

cartodb/app/models/synchronization/member.rb

Line 26 in 9745659

MAX_RETRIES = 10

)

[image: image]
https://cloud.githubusercontent.com/assets/1730320/7471964/9e61fbb6-f32d-11e4-9515-465b98c7396e.png

—
Reply to this email directly or view it on GitHub
#3501 (comment).

David González
Vizzuality
C/. Eloy Gonzalo, 27 2º Puerta 7 - 28010 MADRID
M. +34 609125183
skype: david.gonzalez.camara
www.vizzuality.com

[iriberri]

I really don't know how it works really, it was just guessing after what I've read in the code, so we'd need an expert adding the details here :)

Edit:

It's reseted:

 def set_success_state_from(importer)
        log.append     '******** synchronization succeeded ********'
        self.log_trace      = importer.runner_log_trace
        self.state          = STATE_SUCCESS
        self.etag           = importer.etag
        self.checksum       = importer.checksum
        self.error_code     = nil
        self.error_message  = nil
        self.retried_times  = 0

[ethervoid]

@saleiva I'm going to need the mail body for this :)

[ethervoid]

I have this by now:

[ethervoid]

Due @saleiva is on vacation @carlostallon @piensaenpixel please give some feedback here to close this :)

[piensaenpixel]

take a look

[ethervoid]

Cool!

I have two questions:

• I've put "There was some problem while syncying your dataset" as subject. What do you think?
• Where is the "click here" link goes (url)?

[piensaenpixel]

+1 the first point ok.

The link goes here, http://docs.cartodb.com/cartodb-editor.html#error-codes-and-solutions

[ethervoid]

Ok, thank you :)))

[piensaenpixel]

@ethervoid this copy better, sorry

The automatic synchronization of dataset “XXXX” has reached the maximum number of synchronization attempts—and is still failing to synch. If you'd like to continue trying, log in to your account and manually reactivate synching by clicking “Sync now.”

[ethervoid]

@piensaenpixel what do you think?