Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds asset file upload #11450

Merged
merged 52 commits into from Feb 8, 2017
Merged
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
aa8890f
Aligns asset
javierarce Feb 1, 2017
126d619
Allow adding a custom template for the error view
javierarce Feb 1, 2017
c34ffee
Allows selecting item by name
javierarce Feb 1, 2017
77d0bb4
Stores kind of the selected asset
javierarce Feb 1, 2017
a01327a
Adds file upload for assets
javierarce Feb 2, 2017
34d21ad
Fixes header binding
javierarce Feb 2, 2017
72c9899
Adds opts check
javierarce Feb 2, 2017
6165e59
Removes requirements
javierarce Feb 2, 2017
3692bc4
Fixes selected image
javierarce Feb 2, 2017
03c0be7
Hides disclaimers
javierarce Feb 2, 2017
fbfde21
Removes TODO
javierarce Feb 2, 2017
497072c
Add specs
javierarce Feb 2, 2017
81227f0
Adds hover
javierarce Feb 2, 2017
681b189
Minimal refactor
javierarce Feb 2, 2017
2b60740
Adds more specs
javierarce Feb 2, 2017
eb19874
Little refactor
javierarce Feb 3, 2017
35982b2
Adds cleanup
javierarce Feb 3, 2017
f35bb40
More specs
javierarce Feb 3, 2017
e3186c0
Adds specs and fixes url upload
javierarce Feb 3, 2017
5fa9a71
Adds letter capitalization
javierarce Feb 3, 2017
7f1b82f
Merge with master
javierarce Feb 3, 2017
0a16069
Removes duped file
javierarce Feb 3, 2017
c15238b
Rename method
javierarce Feb 3, 2017
11f9ec2
Revert change
javierarce Feb 3, 2017
0504c3f
Fixes semistandard warnings
javierarce Feb 3, 2017
7682205
Removes redundant code
javierarce Feb 3, 2017
7556ddb
Localices strings
javierarce Feb 7, 2017
4f79a8c
Renames collection, adds listenTo
javierarce Feb 7, 2017
08503ce
Adds listenTo
javierarce Feb 7, 2017
24db72e
Uses collection method for selecting. Refactor
javierarce Feb 7, 2017
abb2d82
Refactors class with CR suggestions
javierarce Feb 7, 2017
c1a1753
moves upload logic to assets-view
javierarce Feb 7, 2017
68dfc59
Updates spec
javierarce Feb 7, 2017
86a6069
Updates spec
javierarce Feb 7, 2017
b5e310f
Updates spec
javierarce Feb 7, 2017
162a8ce
Updates spec
javierarce Feb 7, 2017
9008052
uses new name
javierarce Feb 7, 2017
6a21f85
Refactor
javierarce Feb 7, 2017
e5b7762
Triggers error
javierarce Feb 7, 2017
9666dd5
refactor
javierarce Feb 7, 2017
1deac5b
Adds useful methods. Uses option checker
javierarce Feb 7, 2017
8b44620
Uses unset
javierarce Feb 7, 2017
b4a6467
Uses el instead of
javierarce Feb 7, 2017
e77b404
uses unset
javierarce Feb 7, 2017
b18df38
refactor
javierarce Feb 7, 2017
dbf957e
refactor
javierarce Feb 7, 2017
be37c4e
Refactor
javierarce Feb 7, 2017
b1fcd3f
Fixes test
javierarce Feb 7, 2017
d4ce0f2
Fixes spelling error
javierarce Feb 7, 2017
d47a2c6
Merge branch 'master' into 11020-file-upload
javierarce Feb 7, 2017
5422792
Bump package
javierarce Feb 7, 2017
a8e0d3e
Add missing styling classes
javierarce Feb 8, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -96,20 +96,16 @@ module.exports = CoreView.extend({
return false;
},

_activatedFlag: function () {
return this._userModel && this._userModel.featureEnabled('icon-styling');
_iconStylingEnabled: function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it necessary anymore?

return this._userModel && this._userModel.featureEnabled('icon-styling') && this._imageEnabled;
},

_getKind: function () {
return this._imageEnabled && this.model.get('kind') && this._activatedFlag() ? this.model.get('kind') : '';
return this.model.get('kind') && this._iconStylingEnabled() ? this.model.get('kind') : '';
},

_getImageURL: function () {
return this._imageEnabled && this.model.get('image') && this._activatedFlag() ? this.model.get('image') : '';
},

_iconStylingEnabled: function () {
return this._userModel && this._userModel.featureEnabled('icon-styling') && this._imageEnabled;
return this.model.get('image') && this._iconStylingEnabled() ? this.model.get('image') : '';
},

// Converts reference to the old color ramp to the full color list
Expand Down