Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11583 synced onboarding #11657

Merged
merged 13 commits into from
Mar 2, 2017
Merged

11583 synced onboarding #11657

merged 13 commits into from
Mar 2, 2017

Conversation

ivanmalagon
Copy link
Contributor

@ivanmalagon ivanmalagon commented Feb 28, 2017

Implements #11583

I've done a big refactor on the layer onboardings. This is because for every corner case that we run into, the amount of CSS and custom code is exploding.

The new way of highlighting panels in these onboardings is via selector: we tell the DOM element that we want to focus on and the onboarding goes there programatically. As you can check in the code, this opens a way for having generic onboardings that are very fast to develop and the code has been cut dramatically, especially CSS.

I've also included the closing of the onboarding when clicking on the highlighted panel.

Acceptance

Since the onboardings have suffered a complete refactor we should pass:

  • Original acceptance for layer onboardings -> #11532

  • Check synced layers. The onboarding should highlight correctly the different steps besides having a different height than non synced layers.

  • Check all possible status of feature edition:

    • No edition available: in layers with an applied analysis, for instance.
    • Edit one type of geometry: in layers with geometry, points for instance.
    • Add any geometry: in empty layers, for instance, you can see three buttons instead of one.
  • Check that the onboarding gets closed when clicking the highlighted panel in every possible step.

That's all, folks!

},

clean: function () {
$(document).off('keydown', this._keyDown);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mania, put clean method at the end of the class, because it is the last method to be used. Don't take it into account if you don't want :).

Copy link
Contributor

@xavijam xavijam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb change 🇪🇸. Doing acceptance with pleasure.

@xavijam
Copy link
Contributor

xavijam commented Mar 2, 2017

@matallo, this will affect us with the geocoding onboarding 💋 .

@xavijam
Copy link
Contributor

xavijam commented Mar 2, 2017

Already done the acceptance, perfect man!. Smoother than ever, and working in all cases. Checked in rui account:

  • Onboarding for each type of geometry (lines, polygons, points).
  • Onboarding for a synced layer.
  • Onboarding for a read-only layer.
  • Clicking in the highlighed stuff, close the onboarding.
  • Checked onboarding with different widgets (time-series, categories,...).

@xavijam xavijam merged commit 8baca21 into master Mar 2, 2017
@xavijam xavijam deleted the 11583-synced-onboarding branch March 2, 2017 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants