-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11583 synced onboarding #11657
11583 synced onboarding #11657
Conversation
}, | ||
|
||
clean: function () { | ||
$(document).off('keydown', this._keyDown); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a mania, put clean
method at the end of the class, because it is the last method to be used. Don't take it into account if you don't want :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superb change 🇪🇸. Doing acceptance with pleasure.
@matallo, this will affect us with the geocoding onboarding 💋 . |
Already done the acceptance, perfect man!. Smoother than ever, and working in all cases. Checked in rui account:
|
Implements #11583
I've done a big refactor on the layer onboardings. This is because for every corner case that we run into, the amount of CSS and custom code is exploding.
The new way of highlighting panels in these onboardings is via selector: we tell the DOM element that we want to focus on and the onboarding goes there programatically. As you can check in the code, this opens a way for having generic onboardings that are very fast to develop and the code has been cut dramatically, especially CSS.
I've also included the closing of the onboarding when clicking on the highlighted panel.
Acceptance
Since the onboardings have suffered a complete refactor we should pass:
Original acceptance for layer onboardings -> #11532
Check synced layers. The onboarding should highlight correctly the different steps besides having a different height than non synced layers.
Check all possible status of feature edition:
Check that the onboarding gets closed when clicking the highlighted panel in every possible step.
That's all, folks!