-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating shrinkwrap and package-lock before node.js upgrade #14669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Have in mind that you might need to bump assets version when deploying to production if you want to test assets compilation phase.
NEWS.md
Outdated
@@ -2,7 +2,7 @@ Development | |||
----------- | |||
|
|||
### NOTICES | |||
- None yet | |||
- Updating shrinkwrap and package-lock before node.js upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a silly comment: Can you link this PR there to track the change?
Thanks for the heads up @jesusbotella ! I have already tested without changing the assets version |
Solves: https://github.com/CartoDB/cartodb-platform/issues/5330