Ghost tables visualization_backups migration STEP 2 #14749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 15, 2019
| Proc.new do | ||
| drop_table :visualization_backups | ||
| create_table :visualization_backups do | ||
| Uuid :id, primary_key: true, default: Sequel.lit('uuid_generate_v4()') |
There was a problem hiding this comment.
Use 2 (not 4) spaces for indentation.
Unnecessary spacing detected.
Put one space between the method name and the first argument.
| @@ -0,0 +1,26 @@ | |||
| require 'carto/db/migration_helper' | |||
|
|
|||
| include Carto::Db::MigrationHelper | |||
There was a problem hiding this comment.
include is used at the top level. Use inside class or module.
gonzaloriestra
approved these changes
Mar 18, 2019
ethervoid
reviewed
Mar 18, 2019
ethervoid
reviewed
Mar 18, 2019
ethervoid
approved these changes
Mar 18, 2019
|
@oleurud ready to test in staging after the tests are fixed |
|
The tests won't be green until #14744 will be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 2 of the migration related to #14698
Don't merge after #14744 will be deployed (the tests will fail until the deploy too)