Organize CSS files following 7-1 pattern style #14843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenatorro
reviewed
May 3, 2019
| @import 'utilities/colors'; | ||
| @import 'utilities/flexbox'; | ||
| @import 'utilities/spacing'; | ||
| @import 'utilities/utilities'; |
There was a problem hiding this comment.
Maybe, instead of utilities, in order to avoid repeating the word (utilities/utilities) we could use helpers, general, common, or something similar. What do you think? Maybe it's a pattern and I'm missing something there.
There was a problem hiding this comment.
I've seen abstracts, helpers and utilities. What I like about utilities is that it starts with letter U so main.scss can almost be ordered alphabetically and utilities will be at the end of the file 😄But it's true that the repeating the word (utilities/utilities) is a bit awkward. So changing it to helpers.
elenatorro
reviewed
May 3, 2019
elenatorro
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have moved the
.scssfiles in a similar way to 7-1 pattern. It is not exactly the same. I wanted to keepvariables.scssin the root because they are used in all the components. Also I have renamed some files and moved some code to where I think it fits best.https://sass-guidelin.es/#the-7-1-pattern
Acceptance
Check that the New Dashboard is displayed correctly.
Related Issue
#14670