-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pubsub connection #15389
Add pubsub connection #15389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👏 I've added a few minor comments.
We must remember to carefully test Instagram, Dropbox and Google integrations.
c53d069
to
f477554
Compare
After experiencing some problems with the async publishing of pubsub events in central we decided to try a different approach and replace it by sync publishing through resque jobs. Once we check that approach is working I'll perform the same change in this PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
✔️ Acceptance OK Tested with several events that they are logged and also received in Pub/Sub. |
After reviewing the full list of events and do some cleaning, these are the ones that should be published to pubsub at the moment:
Acceptance: These should appear in Rollbar as info messages and in the corresponding project in Google Cloud every time the action is performed by the user. /cc @gonzaloriestra |
Blocked until the necessary credentials for pubsub are created in production. |
Closes https://github.com/CartoDB/global_metrics/issues/31
As done in https://github.com/CartoDB/cartodb-central/pull/2598, this PR introduces the same PubSubTracker for sending events to PubSub from cartodb. Since in this case we must cover different authentication scenarios (like a future on-premise case), tracker initialization in this implementation includes additional cases.
The idea is to later remove the Segments events so only PubSub ones are sent, thus the duplication of the event models.