Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DO subscription with NULL delivery days #15451

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Fix DO subscription with NULL delivery days #15451

merged 2 commits into from
Feb 4, 2020

Conversation

gonzaloriestra
Copy link
Contributor

When a dataset's metadata has no estimated_delivery_days (NULL), /subscription_info and /subscribe raise an error: https://rollbar.com/carto/CartoDB/items/40907

They should work and return NULL for that field.

@alrocar alrocar self-assigned this Feb 3, 2020
@alrocar
Copy link
Contributor

alrocar commented Feb 3, 2020

Acceptance 🍏

@alrocar alrocar assigned gonzaloriestra and unassigned alrocar Feb 3, 2020
@gonzaloriestra gonzaloriestra merged commit 25612c0 into master Feb 4, 2020
@gonzaloriestra gonzaloriestra deleted the fix-do-subscription-with-null-days branch February 4, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleurud oleurud oleurud approved these changes

Assignees

@gonzaloriestra gonzaloriestra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gonzaloriestra @alrocar @oleurud