Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private map count to /me #15464

Merged
merged 5 commits into from
Feb 10, 2020
Merged

Add private map count to /me #15464

merged 5 commits into from
Feb 10, 2020

Conversation

gonzaloriestra
Copy link
Contributor

Closes #15463

Also, now Kuviz visualizations are taken into account for usage metrics (they were recently included in the quotas).

@alrocar
Copy link
Contributor

alrocar commented Feb 7, 2020

@esloho Could you take a look when you have time, please? 🙏

@alrocar alrocar requested a review from esloho February 7, 2020 07:49
Copy link
Contributor

@esloho esloho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏

Nice small refactor you did there ❇️

app/models/carto/visualization.rb Show resolved Hide resolved
@esloho
Copy link
Contributor

esloho commented Feb 7, 2020

Let me know if I should do the acceptance as well :)

@gonzaloriestra
Copy link
Contributor Author

@esloho thanks! Don't worry about the acceptance, @csubira has to integrate this and I guess she can test it then 🙏

@csubira
Copy link
Contributor

csubira commented Feb 7, 2020

Thanks @esloho and @gonzaloriestra! Acceptance done and it works great! Ready to be merged so we can use it for the rest of the free plan implementation!

@alrocar
Copy link
Contributor

alrocar commented Feb 10, 2020

I'm going to merge it

@alrocar alrocar assigned alrocar and unassigned esloho Feb 10, 2020
@alrocar alrocar merged commit 4d7c96c into master Feb 10, 2020
@alrocar alrocar deleted the private-maps-count branch February 10, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[new price plan] Include private map count in /me
4 participants