deploying apps #15595
Merged
deploying apps #15595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleurud
force-pushed
the
apps-based-on-kuviz
branch
2 times, most recently
from
25f0c3c
to
a40883a
Compare
|
My own acceptance:
I am removing |
gonzaloriestra
approved these changes
Apr 16, 2020
| @@ -39,6 +39,7 @@ class Admin::VisualizationsController < Admin::AdminController | |||
|
|
|||
| before_filter :resolve_visualization_and_table_if_not_cached, only: [:embed_map] | |||
| before_filter :redirect_to_kuviz_if_needed, only: [:embed_map] | |||
| before_filter :redirect_to_app_if_needed, only: [:embed_map] | |||
There was a problem hiding this comment.
I guess there's no need to worry about /embed_map here, but it's not harmful anyway...
Co-Authored-By: Gonzalo Riestra <gonzalor@cartodb.com>
oleurud
force-pushed
the
apps-based-on-kuviz
branch
from
62c3176
to
bce669d
Compare
|
Cache acceptance:
|
|
Ready! It will be deployed tomorrow morning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clubhouse.io/cartoteam/story/67811/backend-for-deploying-apps
Summary:
It needs to be deployed with https://github.com/CartoDB/cartodb-platform/pull/6475