Manage Firewall rules for DB Direct allows IPs #15610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rule name is generated by DbdirectIp and accessible thru the user now, and rule name template is tested.
Co-Authored-By: Gonzalo Riestra <gonzalor@cartodb.com>
…github.com:CartoDB/cartodb into jgoizueta/ch66432/db-direct-allowed-ips-management
…nagement # Conflicts: # NEWS.md
…nagement # Conflicts: # NEWS.md
jgoizueta
deleted the
jgoizueta/ch66432/db-direct-allowed-ips-management
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to create and delete Firewall rules as appropriate to allow the IPs enabled by each organizations for DB direct to reach pgproxy servers.
Firewall rules won't be managed unless it is enabled through the config parameter
dbdirect.firewall.enabled.When enabled a single rule is maintained for each organization; the name of the rule is defined by
DbdirectIp#firewall_rule_nameand uses a template configured bydbdirect.firewall.rule_name.Credentials for using the Google Cloud API to configure the firewall are not handled here (in production we'll be using host service accounts for this purpose)