Remove usages of ::User from ApplicationController #15804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 7, 2020 12:37
rafatower
force-pushed
the
feature/ch101632/remove-usages-of-user-from-applicationcontroller
branch
from
a96d50d
to
e03e2e0
Compare
added 3 commits
September 7, 2020 13:40
and move the compatibility code to ActiveRecordCompatibility module.
rafatower
commented
Sep 7, 2020
| @@ -99,11 +100,6 @@ def static_notifications_with_creation | |||
| end | |||
| alias_method_chain :static_notifications, :creation | |||
|
|
|||
| def invalidate_all_sessions! | |||
| user = ::User.where(id: self.id).first | |||
There was a problem hiding this comment.
#murico: Carto::User dependency upon ::User
This shouldn't matter at Cartodb <-> Central JSON communication API level, but keeping the behavior anyways.
rafatower
changed the title
thedae
reviewed
Sep 7, 2020
app/models/carto/helpers/sessions.rb
Outdated
| @@ -0,0 +1,13 @@ | |||
| module Carto::Sessions | |||
There was a problem hiding this comment.
IMHO, this helper looks like a future "misc" file with tons of code related to sessions.
Since the only responsability of this module is to invalidate sessions, what if we change the purpose and rename it?
I loved the ActiveRecordCompatibility module: it's simple, small and clear
for the sake of specificity, as per review comment.
rafatower
deleted the
feature/ch101632/remove-usages-of-user-from-applicationcontroller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://app.clubhouse.io/cartoteam/story/101632/remove-usages-of-user-from-applicationcontroller
Note: in general warden session black magic internally seems to rely exclusively on username and token, and there's a lot of common stuff already moved to
Carto::UserCommons.Note2: this is built on top of the previous PR #15807