Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a loop between our logger and rollbar #16026

Merged
merged 3 commits into from
Dec 18, 2020

Conversation

rafatower
Copy link
Contributor

@rafatower rafatower commented Dec 18, 2020

See https://app.clubhouse.io/cartoteam/story/126685/infinite-loop-when-rollbar-error-processing

See https://docs.rollbar.com/docs/gem-configuration-reference

default_logger
What logger to use for printing debugging and informational messages during operation.
Default: Logger.new(STDERR) or ::Rails.logger when using Rails

logger
The logger to use instead of the default logger. Especially useful when you wish to send log messages elsewhere.

thanks @amiedes for pointing out

Rafa de la Torre added 2 commits December 18, 2020 15:49
default_logger cannot be assigned:

undefined method `defaul_logger=' for #<Rollbar::ConfiguredOptions:0x000000000379f5b0> (NoMethodError)
@rafatower rafatower force-pushed the change-rollbar-fallback-logger branch from a866522 to 63a8d9d Compare December 18, 2020 14:56
@rafatower rafatower merged commit 28236c5 into master Dec 18, 2020
@rafatower rafatower deleted the change-rollbar-fallback-logger branch December 18, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants