-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SAML & LDAP integrations for on-prem #16239
Fix SAML & LDAP integrations for on-prem #16239
Conversation
This pull request has been linked to Clubhouse Story #144728: Fix SAML Integration for onprem. |
bef0d05
to
4166a44
Compare
@amiedes the test build timed out after 40 min
EDIT: link to the logs https://console.cloud.google.com/cloud-build/builds;region=global/100743d8-e0c5-404a-ace8-de02ba5601b4;step=12?project=cartodb-on-gcp-ci-testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
9d56e95
to
0c15817
Compare
Closer to fix the tests problem: $ cat match-pairs.rb
INPUT_FILE='log-1ec7bd34-a1e3-4530-a35a-447aa6744b4f.txt'
START_RE = /RTORRE Starting example (.*)/
FINISH_RE = /RTORRE Finishing example (.*)/
opened_examples = {}
File.readlines(INPUT_FILE).each do |line|
m = line.match(START_RE)
if m
example = m[1]
opened_examples[example] = true
end
m = line.match(FINISH_RE)
if m
example = m[1]
opened_examples.delete(example)
end
end
puts opened_examples.keys
$ ruby match-pairs.rb
Carto::UserCreation validation token neither creates a new User nor sends the mail and marks creation as failure if Central fails |
NOTE: The ruby timeouts do not work 100% of the time, definitely not in this case, I think because of the threading model, they cannot interrupt the ruby process when it is in a "native" section (most likely sequel pg client waiting for db) |
@amiedes I'm pretty sure it's that evil
I mean, I think I know now how to fix it, but a CI is not very robust if we can get it stuck like that. |
c449ec6
to
c694700
Compare
This happens when a new SAML or LDAP user signs up and it is not yet created in cartodb. It results in a sync call to Central HTTP API. This avoids such call when the Central api is not enabled (notably in on-premise installations). Also this fixes tests that otherwise wait forever on an `until`.
c694700
to
0054534
Compare
Story details: https://app.clubhouse.io/cartoteam/story/144728