Add new events for DO full access #16290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #151531: Metrics. |
added 2 commits
May 24, 2021 13:01
See metrics_controller.rb for more info
ilbambino
approved these changes
May 24, 2021
There was a problem hiding this comment.
LGTM!
But before merging this you should add the new events to criterion, otherwise they won't reach to BigQuery. https://github.com/CartoDB/criterion#how-to-add-new-events
If you need help there, I can help
I know, on it... :) thanks for the prompt review! expect me to bother you with the criterion part pretty soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.clubhouse.io/cartoteam/story/151531
Related PR: https://github.com/CartoDB/criterion/pull/78