Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ch89835] Migrate DO subscription information in inter-cloud migrations #16315

Merged
merged 10 commits into from
Jul 28, 2021

Conversation

Shylpx
Copy link
Collaborator

@Shylpx Shylpx commented Jul 8, 2021

Resources

Context

  • When a user is migrated from one cloud to another, we need to migrate the information about DO subscriptions stored in Redis.

Changes

  • Export/import information stored in Redis about DO subscriptions.
  • Add tests

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #89835: Inter-cloud migrations may leave redis keys behind.

@Shylpx Shylpx self-assigned this Jul 8, 2021
@Shylpx Shylpx requested a review from rafatower July 15, 2021 16:38
Copy link
Contributor

@rafatower rafatower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time I see that RedisExportService o_O

I do agree with ignoring those RSpec/InstanceVariable rubocop complaints

There's a timeout in the onprem build, and seem to happen in the licensing service. I'd ask Infra to sort that out.

Other than that, looks fine to me 👍

@Shylpx Shylpx merged commit ed77caf into master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants