Don't check map quotas during dataset imports #16320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #166179: [reef-admin] Can't import datasets due to 0 public map quota. |
amiedes
force-pushed
the
feature/ch166179/reef-admin-can-t-import-datasets-due-to-0
branch
from
afea881
to
2f6d0b5
Compare
manmorjim
approved these changes
Jul 21, 2021
The thing is that this is already being done, as I tested in the acceptance steps. But it seems like it's done from another place in our code different from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the map quota checks from the dataset imports. I believe if the map quota is exhausted but the user still has dataset quota remaining, we should allow data imports.
I've double checked in acceptance that:
public_map_quota, you can't import a.cartofile containing a public mapprivate_map_quota, you can't import a.cartofile containing a private mapThe reason why I've removed that spec is that even the intention of it is OK: checking the
.cartoimport fails without map quota, the implementation was not right because the test was failing but I checked this in acceptance and was working as expected.Something worth mentioning is that when you upload a dataset, a default visualization of
tabletype is created. With my change we're allowing to create this kind of visualizations even with the map quota is exhausted, but since this visualizations are created by default and are not visible by the user in the UI, I think it was more important to allow the user uploading datasets rather than forbidding it just because some internal stuff we do collides with this approach.