Fix ArcGIS import when there are no features #16322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #164052: [wnc] ArcGIS import fails due to timeout. |
amiedes
force-pushed
the
feature/ch164052/wnc-arcgis-import-fails-due-to-timeout-amiedes-2
branch
from
7fbe0b9
to
60a0eea
Compare
Acceptance in staging ✅Import ArcGIS feature server without dataWe import a feature server we know does not have data:
The import succeeds:
And as a result creates an empty dataset:
Import ArcGIS feature server with dataWe select a feature server we know has data:
And we can see the resulting rows after the import succeeds:
|
amiedes
commented
Jul 27, 2021
| @@ -125,7 +125,15 @@ def run_import! | |||
| log.append("Running on server #{server} with PID: #{Process.pid}") | |||
|
|
|||
| begin | |||
| success = !!dispatch | |||
There was a problem hiding this comment.
This is just a cleanup I did along the way, no behavior changes in this file
amiedes
commented
Jul 27, 2021
| @@ -29,7 +29,7 @@ def @data_import.data_source=(filepath) | |||
| end | |||
|
|
|||
| @data_import.data_source = file_name | |||
| @data_import.send :dispatch | |||
| @data_import.run_import! | |||
There was a problem hiding this comment.
Better call the public API instead of a private method
amiedes
commented
Jul 27, 2021
| @@ -123,6 +123,14 @@ def timed_log(s) | |||
| end | |||
| end | |||
|
|
|||
| def build_empty_initial_stream | |||
There was a problem hiding this comment.
This is the key to the issue: I have to return an empty list of features in order for the dataset to be created with 0 rows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://app.clubhouse.io/cartoteam/story/164052/wnc-arcgis-import-fails-due-to-timeout