Cache geometry_types in redis #2047 #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
|
see #2182 |
…to cache-geometry-types
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
…to cache-geometry-types
|
Frontend tests were OK 👍 (details) |
…to cache-geometry-types
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
…to cache-geometry-types
|
Frontend tests were OK 👍 (details) |
Conflicts: app/models/table.rb
|
Frontend tests were OK 👍 (details) |
added 2 commits
February 13, 2015 11:15
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
rafatower
pushed a commit
that referenced
this pull request
Feb 16, 2015
Cache geometry_types in redis #2047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@javisantana This way we can cache the value from DB in redis. The
expireshould be considered a hint (treated probabilistically). Note it uses its own key. It should work alright in combination with your changes in js.@juanignaciosl this will surely conflict with your PR #2112 but should be easy to merge together.
NOTE: shall not be merged without the changes in js code.