Fix visuals in privacy share permissions view #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved back button to header - Removed subheader - Updated affected views
|
by request, @javierarce can you review this too? |
|
👍 |
|
👀 Looks fine to me 👍 |
Hide eventual overflow on x-axis since it should not be needed in the first place. Show y-axis scroll only if necessary
|
Frontend tests were OK 👍 (details) |
viddo
added a commit
that referenced
this pull request
Feb 25, 2015
Fix visuals in privacy share permissions view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2363