Redirect to list on delete table vis #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 10, 2015 17:24
Depends on user feature flag of new dashboard
|
@xavijam code review please. don't think it's worth adding a test because it's a minimal change and non-critical code path, and since setting up a test case would require setting up a lot of stuff. :/ |
Since new dashboard will render it as datasets as fallback (already done)
| if (self.user.featureEnabled('new_dashboard')) { | ||
| window.location = self.user.viewUrl().dashboard().datasets(); | ||
| } else { | ||
| window.location = cdb.config.prefixUrl() + "/dashboard/tables" |
There was a problem hiding this comment.
I'd only redirect to dashboard/tables because new-dashboard knows how to display datasets although url says tables
|
👍 |
|
Frontend tests were OK 👍 (details) |
viddo
added a commit
that referenced
this pull request
Mar 10, 2015
…-table-vis Redirect to list on delete table vis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2568
Depending on if user has new dashboard or not he/she is redirected to /dashboard/datasets or /dashboard/tables