Fix pagination on new public pages #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem was caused due to changes introduced in create-new-map dialog. Refactor the pagination view to simplify the setup, removing unnecessary binds and enable pagination view/model to allow for desired behaviour in these cases.
| if (ev) { | ||
| ev.preventDefault(); | ||
| } | ||
|
|
|
👍 |
|
Frontend tests were OK 👍 (details) |
viddo
added a commit
that referenced
this pull request
Mar 11, 2015
Fix pagination on new public pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2623
The problem is not really on the public pages but in how the pagination view was changed to work for the create-map dialog, so refactored the code to allow the click-behaviour to work as default. Instead, only block stop event it if a url resolver (
url_to) is not provided (which is the desired behavior for the create map dialog).