2537 update common data metadata task #2741
Conversation
|
Initially I think the proposal is good (to change the message communicated there), I'd get back to this after I finish the current issue I'm working on 👍 |
|
ETA later today. |
|
Good enough? |
To match actual usage, also had duplicate entries
|
Anyway, you can change the texts directly on the file on Github if you want a slightly different text, see https://github.com/CartoDB/cartodb/blob/2537-Update_common_data_metadata_task/lib/assets/javascripts/cartodb/new_dashboard/views/content_no_results.jst.ejs (line 25 and 42) by clicking the pen icon in the top-right corner ("Edit in file"), and change the corresponding text. |
|
reassigned back to you @juanignaciosl merge whenever you consider it to be done :) |
juanignaciosl
changed the title
|
@saleiva we can enable this whenever you want. |
|
Hey one last comment, could we put the loading indicator instead of the icon? Makes sense, right? |
|
IMHO, in that case, since a user might stare the loading icon mesmerized waiting to end, maybe we should add a polling that waits for available data. |
|
Agree. Reassigning it to myself again then. Btw, @juanignaciosl, if you don't have more changes TBD I can take care of doing the merge and release if you prefer? |
|
Take care of it if you want, thank you very much! |
|
Changed the no-results view to a loading view for this use-case. Library data is polled until there are at least one item (every 10 sec, to avoid hammering servers) and/or the user navigates elsewhere. See gif for example below (changed the poll to 2sec for demonstration purposes): |
|
...cc @juanignaciosl @saleiva, if you're OK with this I'll merge & deploy tomorrow morning. |
Fixes #2804, to match account page
…rtoDB/cartodb into 2537-Update_common_data_metadata_task
|
Frontend tests were OK 👍 (details) |
…a_task 2537 update common data metadata task
@viddo could you make front part consistent with this? I'd only change "Data Library" text message, but you're free to add whatever you want. When we launch this, common data loading/update will be triggered when a user has not loaded it or has not updated it in a month. Load time is in the order of one minute.
edit: fixes #2537 (for reference) /viddo