Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bubble wizard legend not being updated on column change #2747

Merged
merged 5 commits into from
Mar 13, 2015

Conversation

viddo
Copy link
Contributor

@viddo viddo commented Mar 12, 2015

Fixes #2594

There are two issues:

  1. Changed the default lock state to be off, so the values are updated as expected. If set manually to locked they will not be updated even if changing column later on (AFAIK this is the desired behavior of this lock state).
  2. Even if I fixed 1, when changing to bubble wizard from another it did not always update the legend if some other props happened to be the same.

While at it also did some cleanup on the formatting to adhere to the informal standard.

bubble-legends

Bonus: Fixed this test case that caused the annoying JS error output (not failing test though) on stdout:

..........>> TypeError: 'undefined' is not an object (evaluating 'tbl.offsetWidth') at
>> vendor/assets/javascripts/datepicker.js:458
>> vendor/assets/javascripts/datepicker.js:770
>> vendor/assets/javascripts/cartodb.uncompressed.js:25
>> vendor/assets/javascripts/cartodb.uncompressed.js:25
>> vendor/assets/javascripts/datepicker.js:776
>> lib/assets/javascripts/cartodb/common/import/custom_datepicker.js:135
>> lib/assets/javascripts/cartodb/common/import/custom_datepicker.js:63
....

Nicklas Gummesson added 4 commits March 12, 2015 17:55
Added missing test cases and verify working
Been disabled for +1 year and according to docs should not happen
anyway so… not point in maintaining them
@viddo
Copy link
Contributor Author

viddo commented Mar 12, 2015

I guess you @javierarce is the best candidate to review this since you did the original code related to the lock state.

cc @saleiva

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@saleiva
Copy link
Contributor

saleiva commented Mar 12, 2015

🙌

@viddo viddo changed the title 2594 fix bubble wizard legend Fix bubble wizard legend not being updated on column change Mar 12, 2015
@javierarce
Copy link
Contributor

Perfect 🎏

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

viddo added a commit that referenced this pull request Mar 13, 2015
Fix bubble wizard legend not being updated on column change
@viddo viddo merged commit f85194f into master Mar 13, 2015
@viddo viddo deleted the 2594-fix-bubble-wizard-legend branch March 13, 2015 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bubble map legends don't re-legend on Column change
4 participants