2585 csv regression fix #2847
Merged
2585 csv regression fix #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 20, 2015 13:48
This fix shows an 'Encoding detection error (2002)' for the following exception: ``` Encoding::UndefinedConversionError: "\x8D" to UTF-8 in conversion from Windows-1252 to UTF-8 ```
The line breaks test worked in clinker just by chance, most likely due to an old version of charlock_holmes
|
Frontend tests were OK 👍 (details) |
|
👍 |
|
This is the difference between production and clinker:
This affects the CSV implementation, which is part of ruby's stdlib. I'm deactivating that test for the moment, once merged in master for a while I'm gonna ask them to modify their installation in order to avoid disruption in the release process |
|
Frontend tests were OK 👍 (details) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Kartones CR please