Sort category names alphabetically in legends

[alonsogarciapablo]

Fixes #2808.

[Cartofante]

Frontend tests were OK 👍 (details)

[alonsogarciapablo]

@javisantana, this seems to get the job done. 👍

Another option would be to sort the categories here.

[javisantana]

i love when things work by chance 🇪🇸

as a side comment, all those functions that we have to get analytics from a table should be in cartodb.js/src/api/sql.js

The reason is that a lot of times the user want to get stats from the table and they need to do their own queries so having:

var sql = cartodb.SQL({ username: 'rambo' });
sql.categoriesForColumn(...., function() {
});

But there is another reason to do that. Postgres has its own statistics for columns in tables, so for example we could have a "fast" path for this using pg_stats which collections information for columns:

# select chr((65 + round(random() * 25))::integer) as ch into table_test from generate_series(1, 100000);
SELECT 100000
# select most_common_vals, most_common_freqs from pg_stats where tablename = 'table_test';
                   most_common_vals                    |                                                                                                                     most_common_freqs
-------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 {X,L,S,Y,P,J,O,F,T,D,N,Q,K,B,W,E,C,U,G,H,M,I,R,V,Z,A} | {0.0433333,0.0414667,0.0410667,0.0409667,0.0408,0.0405667,0.0405667,0.0404667,0.0404667,0.0403333,0.0402333,0.0402333,0.0401667,0.0396667,0.0396667,0.0396333,0.0393333,0.0391667,0.0391333,0.0388667,0.0387667,0.0387333,0.0383,0.0380667,0.0203,0.0197}

cc @CartoDB/frontend

[viddo]

Thx for the info! Although, I'm thinking, apart from informing us in-context here, shouldn't this be documented somewhere?

[xavijam]

Agree with @viddo.

[xavijam]

In any case 👍

[javisantana]

@viddo what do you mean with documented?

[Cartofante]

Frontend tests were OK 👍 (details)

[viddo]

..., all those functions that we have to get analytics from a table should be in cartodb.js/src/api/sql.js

I interpret this as there are functions that should be located in the sql.js there are currently located elsewhere (where they shouldn't be). But how would should we know? After reading this issue we will have it in the back of our heads (at best), but what about new people joining the project in the future?

So, what I mean with documented is that this decision/convention/guideline should be written down and explained (like above), e.g. in the wiki or a versioned doc/ dir.

[alonsogarciapablo]

@javisantana PTAL at this final commit.

[Cartofante]

Frontend tests were OK 👍 (details)

[javisantana]

🇪🇸

[Cartofante]

Frontend tests were OK 👍 (details)

[Cartofante]

Frontend tests were OK 👍 (details)

[andy-esch]

thanks for the sorting, you guys are superstars