Fixes custom image header templates #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var url = this._getCoverURL(); | ||
|
|
||
| if (!this._isValidURL(url)) { | ||
| $imageNotFound.fadeIn(250); | ||
| $img.hide(); |
There was a problem hiding this comment.
We were not hiding the <img> tag before, and it was displaying a broken image (bonus)
|
Frontend tests were OK 👍 (details) |
alonsogarciapablo
changed the title
|
Hey @xavijam, when you have a second, I'd love to have your thoughts on this PR. Thanks! |
|
|
||
| var $cover = this.$el.find(".cover"); |
|
Shouldn't we change the same function in cartodb.js infowindow file? |
|
Frontend tests were OK 👍 (details) |
|
@xavijam I fixed the selectors. As per your other comment, I'd say that should also be changed in cartodb.js, but since nobody has complaint about it, I think we can wait. |
|
Open a ticket please :) |
|
@xavijam: There you have it. Thanks! |
alonsogarciapablo
added a commit
that referenced
this pull request
Apr 28, 2015
…mplates Fixes custom image header templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2235 and hides the
<img>tag when an infowindow doesn't have a valid cover URL (different issue).cc/ @cshirky