Fixing problem rendering Lato font

[xavijam]

We have a really big problem rendering Lato font with our font generated files. So @matallo has suggested to use webfontloader for loading them from Google, and if they aren't loaded, load the local ones (perfect for on-premise case). I feel it is a good option, what do you think?

@CartoDB/frontend

Fixes #3461.

[xavijam]

I haven't done anything yet, this it for discussion.

[Cartofante]

Frontend tests were OK 👍 (details)

[xavijam]

@matallo approach done, @viddo could you check it?

[xavijam]

custom install, onpremise,...

cc @javisantana

[Cartofante]

Frontend tests were OK 👍 (details)

[viddo]

Solution itself looks legit, but why is it that the font loading fails when loaded "locally" (CDN?) in the first place?

[xavijam]

I don't get you @viddo sorry. fontinactive is an event triggered when the fonts haven't been loaded, then we load the local ones. They only are loaded from the beginning if the editor is a "custom_install" type.

[Cartofante]

Frontend tests were OK 👍 (details)

[alonsogarciapablo]

I'm personally missing some context here too. As @viddo said, solution looks good, but I'm not sure what the real problem is.

[matallo]

I find this awesome, good job @xavijam

[xavijam]

@alonsogarciapablo We had problems rendering Lato font using it locally, before being loaded, weird characters appeared in the texts with that font applied (unfortunately i don't have an screenshot right now). After checking what we do in CartoDB website, I feel this way is way better, and without forgetting open source and offline users.

[Cartofante]

Frontend tests were OK 👍 (details)

[alonsogarciapablo]

@xavijam I guess you're referring to this:

Thanks for the context and the quick fix!

[xavijam]

Yep, that thing :(

On 4 May 2015 at 15:26:18, Pablo Alonso (notifications@github.com) wrote:

@xavijam I guess you're referring to this:

Thanks for the context and the quick fix!

—
Reply to this email directly or view it on GitHub.