Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend cleaning #3563

Merged
merged 25 commits into from May 11, 2015
Merged

Frontend cleaning #3563

merged 25 commits into from May 11, 2015

Conversation

xavijam
Copy link
Contributor

@xavijam xavijam commented May 7, 2015

Concerns

  • Common submodule now called old_common (changes in .gitsubmodule !!! ).
  • Error and static html pages don't require external js, css or images anymore, new style included.
  • Removed unnecessary assets, starting with CSS, images and sprites.
  • Renamed js old common folder to old_common. And new_common is now the new common.
  • Removed unnecesary and old JS and JST files.
  • Replaced common, new_common, new_dashboard, new_organization, etc etc ... things.
  • S3 upload improved.

@CartoDB/frontend

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@recena
Copy link

recena commented May 8, 2015

retest this please

1 similar comment
@recena
Copy link

recena commented May 8, 2015

retest this please

@xavijam
Copy link
Contributor Author

xavijam commented May 8, 2015

Now test are failing due to any of my faults, sorry!

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@recena
Copy link

recena commented May 8, 2015

@xavijam Nice work!

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

xavijam added a commit that referenced this pull request May 11, 2015
@xavijam
Merge pull request #3563 from CartoDB/frontent-cleaning
8fe1562 
Frontend cleaning
@xavijam xavijam merged commit 8fe1562 into master May 11, 2015
@xavijam xavijam deleted the frontent-cleaning branch May 11, 2015 09:01
@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xavijam @Cartofante @recena