3621 fix disappear custom infowindow #3755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 25, 2015 16:54
|
yep, is strange, because should be 2 times, once for the all_xxx and one for the invalidate_cache. Anyway, +1 here |
|
Frontend tests were OK 👍 (details) |
rafatower
pushed a commit
that referenced
this pull request
May 26, 2015
…indow 3621 fix disappear custom infowindow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things in this review:
s/invalidate_all_visualizations_cache/invalidate_all_varnish_vizjon_keysVisualization::Member#invalidate_cachethat deals with all caches related to a member.I'm fully aware the change
times(1) -> times(3)is not good. That needs a review, either in the member legacy classes or the refactored ones. I'm creating a ticket for it.@Kartones please review