Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cache geocodes if the_geom is NULL #3793

Merged
merged 1 commit into from
May 27, 2015
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion services/table-geocoder/lib/geocoder_cache.rb
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ def store
WHERE orig.cartodb_georef_status IS NOT NULL
LIMIT #{@batch_size} OFFSET #{count * @batch_size}
}).all
sql.gsub! '%%VALUES%%', rows.map { |r| "(#{r[:searchtext]}, #{(r[:the_geom] == nil ? 'NULL' : "'#{r[:the_geom]}'")})" }.join(',')
rows.reject! { |r| r[:the_geom] == nil }
sql.gsub! '%%VALUES%%', rows.map { |r| "(#{r[:searchtext]}, '#{r[:the_geom]}')" }.join(',')
run_query(sql) if rows && rows.size > 0
end while rows.size >= @batch_size
rescue => e
Expand Down