Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4730 ogr xy possible names #5349

Merged
merged 5 commits into from
Sep 7, 2015
Merged

4730 ogr xy possible names #5349

merged 5 commits into from
Sep 7, 2015

Conversation

rafatower
Copy link
Contributor

What this does:

  • Moves [LAT|LONG]_POSSIBLE_NAMES to the Ogr2ogr class, removing it from the Georeferencer
  • Removes georeferencer tests related to that feature, no longer the responsibility of rails code but ogr2ogr2
  • Adds a specific integration test to check that the table is indeed imported correctly with the new ogr2ogr2 binary.

@Kartones can you please review?

Rafa de la Torre added 3 commits September 4, 2015 15:33
This is now responsibility of ogr2ogr so avoid doing the same thing
twice.
Not used and has never been its responsiblity.
@rafatower rafatower changed the title [NOMERGE] 4730 ogr xy possible names 4730 ogr xy possible names Sep 4, 2015
@Kartones
Copy link
Contributor

Kartones commented Sep 7, 2015

👍 Nice!

rafatower pushed a commit that referenced this pull request Sep 7, 2015
@rafatower rafatower merged commit c30ee49 into master Sep 7, 2015
@rafatower rafatower deleted the 4730-ogr-xy-possible-names branch September 7, 2015 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants