New Visualization Backups table #5776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@juanignaciosl CR please (although is so dumb I'm not sure it needs CR) |
9 tasks
| String :username, null: false | ||
| Uuid :visualization, null: false | ||
| String :export_vizjson, null: false | ||
| DateTime :created_at, default: Sequel::CURRENT_TIMESTAMP |
There was a problem hiding this comment.
- It would be nice having a
:sourcefield with the cause of the backup (ghost tables, manual deletion, whatever). - We should push type safety and make
:export_vizjsonjson type. I've had some discussions about this forcdb_confand we finally pushed for json type as well.
There was a problem hiding this comment.
- The source/type of backup will come but inside the
export_vizjson, as it already requires some extra things like versioning, always exporting all layers, an owner... So taken care inside there. - The idea is to have a quickly working solution without much logic at this level, that's why also there are no constraints at other fields, so I'd rather build something really simple and if later given time to, improve the data type.
But thanks for the suggestion, if we iterate over this I'll surely change the type, is just that the biggest requisite is "have it fast" so making tradeoffs wherever I can to achieve it.
|
👍 after my suggestions, both up to you. |
Kartones
added a commit
that referenced
this pull request
Sep 28, 2015
New Visualization Backups table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #5710
Just the migration to add the DB table