link infowindows with cartodb_id #8127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure if I'm the best to review this one since I don't know so much about the queryModel |
| return m.get('name') === 'cartodb_id'; | ||
| }); | ||
|
|
||
| if (cartdb_id) { |
There was a problem hiding this comment.
So, what would/should happen if isEmptyTemplate and there's no cartodb_id column in the results? This scenario could happen if the node results is not available yet for example.
There was a problem hiding this comment.
it would apply the changes in the map infowindow from the attributes passed in the change event
|
Looks legit, added a small comment re: a detail that this change introduce I wasn't sure about though. Also, while I was explained offline why this change was necessary I'd prefer to have a test case that outlines and asserts the scenario. |
|
yeah, tests on their way, right now they are broken :/ |
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CR @javisantana