-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/962 pandas integration #1014
Conversation
Maybe @oleurud would like to CR this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the message in the DiscoveryException, I am not sure at all, I think a user is not going to understand the message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go!
A comment for future PRs: I think we can extract some common methods of the entities to a parent class making the code easy to maintain
Agree. I tried at first but there wasn't much that could be extracted. I'll give it another look now that we have more methods :) Thanks! |
Acceptance 🍏 |
Closes #962
Regarding the second problem exposed in the issue #962 we had to compromised: we'll raise an exception when trying to access with a column Series any method that requires a row Series.
When asking for all the datasets by a particular category (
Category.datasets()
), that Category instance must represent a single entity like when using loc/iloc in a DataFrame or when using theget_by_id
method. But if it represents a column like when accessing a property of the DataFrame (Categories['name']
) there's not a singleid
we can use to search the associated datasets. Ideally these cases shouldn't be represented as Category instances, but since we couldn't find a way to avoid it let's try this solution.This PR also includes a missing change in last PR: return
None
(instead of empty list) when no entities are found in the server.