Use do token in enrichment #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Alberto Romeu <alrocar@users.noreply.github.com>
# Conflicts: # cartoframes/data/dataset/registry/dataframe_dataset.py # test/data/dataset/test_dataset.py
Support uploading DataFrames with non-ascii texts in Python 2
alrocar
approved these changes
Sep 26, 2019
|
|
||
| @refresh_client |
| def query(self, query, **kwargs): | ||
| response = self.client.query(query, **kwargs) | ||
|
|
||
| return response | ||
|
|
||
| @refresh_client | ||
| def delete_table(self, tablename, project, dataset): |
There was a problem hiding this comment.
User tokens are not granted to delete tables. Instead of that we added a TTL for tables.
Please consider removing this method.
cc. @alejandrohall
There was a problem hiding this comment.
Ok, @alejandrohall is working on a refactor of the enrichment methods. Since this one applies there, we will tackle it there
|
I'd like we do acceptance of this task with an actual customer dataset in BQ. Is that possible yet? |
|
We have not created the views yet |
|
I am going to change the destination branch to #1034 to validate everything together |
oleurud
changed the base branch from
develop
to
refactor/refactor_enrichment_functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves a part of https://github.com/CartoDB/data-observatory/issues/147