docstring edits and additions #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 25, 2019
houndci-bot
reviewed
Sep 26, 2019
houndci-bot
reviewed
Sep 26, 2019
|
Hi @andy-esch! I was taking a look at this PR and, and a lot of things have changed since it was opened. Before the beta 4 release, we'll need to review the docstring reference, so we can add these changes then. Do you think we can close this PR? Or could you modify it to solve conflicts in case we want to add these changes now? Thank you! |
|
Hey @elenatorro! I'll merge current develop into this branch locally to see if this PR still adds anything of value. I'll ping back here either way. |
houndci-bot
reviewed
Oct 23, 2019
|
Hey @elenatorro, I fixed all the conflicts and hopefully got everything in the right place! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@elenatorro, I'm starting to tackle some of the docstring documentation