Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable group to discovery model #1036

Merged
merged 4 commits into from
Oct 1, 2019
Merged

Conversation

esloho
Copy link
Contributor

@esloho esloho commented Sep 27, 2019

Closes #983

Add the concept variable_group to the discovery model and methods for:

  • Getting the variables that belong to a variable group
  • Getting the variables_groups for a given dataset

Copy link
Contributor

@oleurud oleurud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks cool!

@oleurud oleurud self-assigned this Oct 1, 2019
@oleurud
Copy link
Contributor

oleurud commented Oct 1, 2019

A question, should we add a variable_group method in Variable?

@esloho
Copy link
Contributor Author

esloho commented Oct 1, 2019

A question, should we add a variable_group method in Variable?

Current implementation returns the id, as it does with the other properties. However, I think we should consider if that's the behavior we want or if we should return the entity itself and not only the id.

Since we're about to have a new version of the catalog with a different approach, I propose to address this point in the new model and leave this PR as it is.

@oleurud
Copy link
Contributor

oleurud commented Oct 1, 2019

Acceptance OK

@oleurud oleurud merged commit e5c4520 into develop Oct 1, 2019
@oleurud oleurud deleted the feature/983-variable-groups branch October 1, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support variable_groups
3 participants