Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty geometries in Source #1610

Merged
merged 2 commits into from Apr 3, 2020
Merged

Remove empty geometries in Source #1610

merged 2 commits into from Apr 3, 2020

Conversation

Jesus89
Copy link
Member

@Jesus89 Jesus89 commented Apr 3, 2020

No description provided.

cmongut
cmongut reviewed Apr 3, 2020
View reviewed changes
Copy link
Contributor

@cmongut cmongut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we remove them instead of raising an error?

@Jesus89
Copy link
Member Author

Jesus89 commented Apr 3, 2020

Yes

@Jesus89 Jesus89 merged commit e59245e into release/1.0.2 Apr 3, 2020
@Jesus89 Jesus89 deleted the jarroyo/ch66629/downloading-a-carto-table-may-return-two branch April 3, 2020 14:04
@Jesus89 Jesus89 changed the title Check empty geometries in Source Remove empty geometries in Source Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmongut cmongut cmongut left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jesus89 @cmongut