Clean old API #871
Merged
Clean old API #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-esch
reviewed
Jul 24, 2019
| @@ -122,6 +121,10 @@ def set_default_credentials( | |||
| _default_credentials.session = session | |||
|
|
|||
|
|
|||
| def _is_url(text): | |||
| return re.match(r'^https?://.*$', text) | |||
There was a problem hiding this comment.
What happens if the user enters http://username.carto.com? This will return False, but is that still a valid URL for API calls? If so, should we coerce it to https or give a warning?
There was a problem hiding this comment.
http should work, because of the ?
There was a problem hiding this comment.
Works, I checked it the first time I saw it
There was a problem hiding this comment.
Great. Should we coerce to https?
There was a problem hiding this comment.
I am not sure. base_url is used mainly by onpremises, right? In this case, I suppose we shouldn't require https. What do you see it?
Jesus89
reviewed
Jul 24, 2019
cartoframes/examples.py
Outdated
| @@ -110,7 +111,7 @@ class Examples(Context): | |||
| """ | |||
|
|
|||
| def __init__(self): | |||
| super(Examples, self).__init__( | |||
| set_default_credentials( | |||
There was a problem hiding this comment.
Use self._credentials = Credentials(... instead
Jesus89
requested changes
Jul 25, 2019
houndci-bot
reviewed
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #807 & #624
I have created a table file in data namespace to include the tables method from context