Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in upload, if creds are None, use default creds #969

Merged
merged 1 commit into from
Sep 11, 2019
Merged

in upload, if creds are None, use default creds #969

merged 1 commit into from
Sep 11, 2019

Conversation

oleurud
Copy link
Contributor

@oleurud oleurud commented Sep 11, 2019

Fix #913

@oleurud oleurud added the bug label Sep 11, 2019
@oleurud oleurud requested a review from esloho September 11, 2019 11:41
esloho
esloho approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@esloho esloho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@andy-esch
Copy link
Contributor

💥 Thank you, looks great!

@oleurud oleurud merged commit bacce3d into develop Sep 11, 2019
@oleurud oleurud deleted the fix/913-upload-default-creds branch September 11, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-esch andy-esch andy-esch approved these changes

@esloho esloho esloho approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dataset().upload() does not work with default credentials
3 participants
@oleurud @andy-esch @esloho