Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update carto to upstream version #52

Open
strk opened this issue Mar 29, 2013 · 5 comments
Open

Update carto to upstream version #52

strk opened this issue Mar 29, 2013 · 5 comments
Assignees
@strk

Comments

@strk
Copy link
Contributor

strk commented Mar 29, 2013

The reason why we're using our own fork is to allow using mapnik-geometry-type in filters. This is still being debated upstream: mapbox/carto#207
@ghost ghost assigned strk Mar 29, 2013
@strk
Copy link
Contributor Author

strk commented Aug 13, 2013

We need the upstream version also for this: mapbox/carto#289 (needs to be merged in our fork if we continue using our fork)

This was referenced Sep 4, 2013
Closed
Closed
@strk
Copy link
Contributor Author

strk commented Sep 12, 2013

I think we'll never officially get support for mapnik-geometry-type so the plan is to internally convert the styles to replace that with "mapnik::geometry_type". It should work, but it'll need careful testing.

@strk strk mentioned this issue Oct 3, 2013
Closed
@strk strk mentioned this issue Oct 23, 2013
Closed
@strk
Copy link
Contributor Author

strk commented Oct 28, 2013

As of carto-0.9.5 the only thing missing to switch to upstream is this being still unmerged:
mapbox/carto#307 (single quote escaping)

strk pushed a commit that referenced this issue Oct 28, 2013
Rework mapnik-geometry-type handling to always run for ver < 2.2.0
b696eb0 
This is to allow getting back to track upstream carto version
See #67 and #52
strk pushed a commit that referenced this issue Oct 28, 2013
Yet another round for mapnik-geometry-type handling
0dbb27a 
This commit:

 - Fixes the testsuite
 - Also convert for sources in the ~2.1.1 range.

See #67 and #52
strk pushed a commit that referenced this issue Oct 28, 2013
Update carto to 0.9.5-cdb1, closer to upstream (#52)
a8a9e2c
@strk
Copy link
Contributor Author

strk commented Nov 7, 2013

Another blocker for upstream sync: mapbox/carto#314

@strk
Copy link
Contributor Author

strk commented Nov 26, 2013

Exponential notation fix was merged, so we're back to only missing the single quote escaping: mapbox/carto#307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@strk strk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@strk