Separate geom from data calcs #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
talos
commented
Mar 9, 2017
•
talos
commented
- Use a CTE to perform geometry intersections between user geometries and Observatory geometries
talos
commented
Mar 9, 2017
| @@ -536,9 +536,12 @@ RETURNS TABLE ( | |||
| ) | |||
| AS $$ | |||
| DECLARE | |||
There was a problem hiding this comment.
@michellemho Starting here is where I made changes to use a CTE to do geometry intersections.
| @@ -579,7 +582,20 @@ BEGIN | |||
| (unnest($1))->>'api_method' api_method, | |||
| (unnest($1))->'api_args' api_args | |||
| ) | |||
| SELECT String_Agg( | |||
| SELECT | |||
There was a problem hiding this comment.
@michellemho This is where the geometry intersections are defined.
| ' / Nullif(ST_Area(' || geom_tablename || '.' || geom_colname || '), 0))' || | ||
| ' END), 0) ' || | ||
| ' / (COUNT(*) / COUNT(distinct ' || geom_tablename || '.' || geom_geomref_colname || ')) ' | ||
| ' * pct_' || geom_tablename || |
There was a problem hiding this comment.
These parts where a lot of code was removed are possible because the geometry intersections were done in the CTE.
| SELECT _geoms.id::INT, Array_to_JSON(ARRAY[%s]::JSON[]) | ||
| FROM _geoms, %s | ||
| FROM _raw_geoms), | ||
| _procgeoms AS (SELECT _geoms.id, _geoms.geom, %s %s |
talos
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.