Adjusts tile xy value when coordinates are out of bounds #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@javisantana review! |
|
is there a reason why here (https://github.com/CartoDB/torque/blob/coord-wrap/lib/torque/provider/windshaft.js#L296) corrected is not used? |
|
Yep: we need to callback the tile rendering function with the original tile numbers, not the corrected ones, otherwise they will only render in the "corrected" tile positions (i.e. the ones within the normal coordinate ranges). We only need corrected values to ask the server for the right tiles. |
|
nice, thanks 🇪🇸 |
|
|
fdansv
added a commit
that referenced
this pull request
Jan 13, 2015
Adjusts tile xy value when coordinates are out of bounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #82
Same problem, I was using the wrong branch in the previous PR.
@javisantana