Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix agg columns reinstantiation #92

Merged
merged 1 commit into from Jul 17, 2020
Merged

fix agg columns reinstantiation #92

merged 1 commit into from Jul 17, 2020

Conversation

oleurud
Copy link
Contributor

@oleurud oleurud commented Jul 17, 2020 •
edited

when local filtered and agg columns exist, we are always doing a reinstantiation with the very same values

@vercel
Copy link

vercel bot commented Jul 17, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carto-frontend/web-sdk/li9nk5sl8
✅ Preview: https://web-sdk-git-fix-agg-columns-reinstantiation.carto-frontend.vercel.app

manmorjim
manmorjim approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@manmorjim manmorjim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🚀

@oleurud oleurud changed the title fix agg columns reinstantiation too much calls to Maps API Jul 17, 2020
@oleurud oleurud changed the title too much calls to Maps API fix agg columns reinstantiation Jul 17, 2020
@oleurud oleurud force-pushed the fix-agg-columns-reinstantiation branch from cf62f07 to b124be7 Compare July 17, 2020 11:45
@oleurud oleurud merged commit d8f1426 into develop Jul 17, 2020
@oleurud oleurud deleted the fix-agg-columns-reinstantiation branch July 17, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manmorjim manmorjim manmorjim approved these changes

@jesusbotella jesusbotella jesusbotella approved these changes

Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oleurud @manmorjim @jesusbotella